test: add 70 tests for Agent.pm#51
Merged
Merged
Conversation
…local_check) Agent.pm had zero test coverage despite being the main entry point. These tests cover the testable surface without requiring network access: - Constructor validation for all 4 breeds plus invalid input - parse_mbox: single RFC822, mbox splitting, >From quoting, aref/fh input - local_check: mailing-list detection, whitelist matching, regex patterns - read_whitelist: file parsing, key lowercasing, caching behavior - _help text generation for all breeds - log/logll behavior with and without logref Also fix MANIFEST.SKIP to exclude build artifacts (.o, .bs, generated .c). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First test coverage for Agent.pm — 70 tests covering the module's testable surface without network access.
Why
Agent.pm is the main entry point (constructor, mbox parsing, whitelist, local checks) yet had zero test coverage. These tests lock down behavior for the pure-logic paths.
How
parse_mbox: RFC822, mbox splitting,>Fromquoting, aref/fh input, empty fileslocal_check: List-Id detection (with/without ignorelist), folded headersread_whitelist: file parsing, key lowercasing, regex patterns, caching_helptext for all breeds,log/logllwith and without logref.o,.bs, generated.c)Testing
🤖 Generated with Claude Code
Quality Report
Changes: 3 files changed, 536 insertions(+)
Code scan: 1 issue(s) found
t/agent.t:0— 532 lines addedTests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline