Revert "fix: replace two-arg open with three-arg form in Agent.pm"#59
Closed
mdierksen wants to merge 1 commit into
Closed
Revert "fix: replace two-arg open with three-arg form in Agent.pm"#59mdierksen wants to merge 1 commit into
mdierksen wants to merge 1 commit into
Conversation
This reverts commit 9f8da66. The commit breaks input from stdin. Apparently our glorious and wise AI overlord Claude Opus 4.6 cannot be arsed to test its changes at all because otherwise it would have noticed that simply calling the razor-check binary with no arguments produces the error message "Can't open -: No such file or directory" and an error return code.
Member
|
This was put in specifically at my direction and reviewed by me. Can you clarify what the error is because converting a 2 arg to a 3 arg is only an error if you have a VERY strange file name. |
Member
|
@toddr-bot review |
Author
It breaks input from stdin. |
Member
|
I'm replacing this with #60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f8da66.
The commit breaks input from stdin.
Apparently our glorious and wise AI overlord Claude Opus 4.6 cannot be arsed to test its changes at all because otherwise it would have noticed that simply calling the razor-check binary with no arguments produces the error message "Can't open -: No such file or directory" and an error return code.