Skip to content

fix: use done_testing() without explicit test count #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: use done_testing() without explicit test count #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions t/200_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 295;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -179,6 +178,5 @@ foreach my $attr ("pivot", "transpose") {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/201_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 12;
use Test::More;
require Test::NoWarnings;

Expand All @@ -30,6 +29,5 @@ is ($csv->[1]{C3}, "C3", "cell C3");

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/202_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 4;
use Test::More;
require Test::NoWarnings;

Expand All @@ -25,9 +24,8 @@ is ($csv->[1]{cell}[$csv->[1]{maxcol}][$csv->[1]{maxrow}],

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();

__END__
ok (1, "Defined fields");
Expand Down
4 changes: 1 addition & 3 deletions t/203_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 125;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -111,6 +110,5 @@ else {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/204_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 118;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -90,6 +89,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/205_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

# OO version of 200_csv.t

my $tests = 275;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -254,6 +253,5 @@ is_deeply ($csv->sheet (1)->cellrange (-1, -1, -1, -1), [

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/210_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_XS"; }

my $tests = 171;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -160,6 +159,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/211_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_XS"; }

my $tests = 12;
use Test::More;
require Test::NoWarnings;

Expand All @@ -32,6 +31,5 @@ is ($csv->[1]{C3}, "C3", "cell C3");

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/212_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_XS"; }

my $tests = 4;
use Test::More;
require Test::NoWarnings;

Expand All @@ -24,9 +23,8 @@ is ($csv->[1]{cell}[$csv->[1]{maxcol}][$csv->[1]{maxrow}],

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();

__END__
ok (1, "Defined fields");
Expand Down
4 changes: 1 addition & 3 deletions t/213_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_XS"; }

my $tests = 117;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -92,6 +91,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/214_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_XS"; }

my $tests = 118;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -92,6 +91,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/220_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_PP"; }

my $tests = 171;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -160,6 +159,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/221_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_PP"; }

my $tests = 12;
use Test::More;
require Test::NoWarnings;

Expand All @@ -32,6 +31,5 @@ is ($csv->[1]{C3}, "C3", "cell C3");

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/222_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_PP"; }

my $tests = 4;
use Test::More;
require Test::NoWarnings;

Expand All @@ -25,9 +24,8 @@ is ($csv->[1]{cell}[$csv->[1]{maxcol}][$csv->[1]{maxrow}],

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();

__END__
ok (1, "Defined fields");
Expand Down
4 changes: 1 addition & 3 deletions t/223_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_PP"; }

my $tests = 117;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -92,6 +91,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/224_csv.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_CSV} = "Text::CSV_PP"; }

my $tests = 118;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -92,6 +91,5 @@ foreach my $cell (qw( B3 C1 C2 D2 D4 )) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/31_clr.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 256;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -44,6 +43,5 @@ foreach my $col (1 .. $#clr) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/32_fmt.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 39;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -48,6 +47,5 @@ foreach my $r (2 .. 9, 11, 12) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/33_misc.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 6;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -55,6 +54,5 @@ ok ($xls, "Open with options, let's see if we get any warnings");

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/34_dates.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 103;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -70,6 +69,5 @@ foreach my $r (1..4,6..7) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/35_perc.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use strict;
use warnings;

my $tests = 77;
use Test::More;
require Test::NoWarnings;

Expand All @@ -28,6 +27,5 @@ foreach my $row (1 .. 19) {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
6 changes: 2 additions & 4 deletions t/410_ods.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_ODS} = "Spreadsheet::ParseODS"; }

my $tests = 128;
use Test::More;
require Test::NoWarnings;

Expand All @@ -17,7 +16,7 @@ my $parser = Spreadsheet::Read::parses ("ods") or
my $pv = $parser->VERSION;
print STDERR "# Parser: $parser-$pv\n";

my $notyet = $pv lt "0.25" and $tests -= 10;
my $notyet = $pv lt "0.25";

{ my $ref;
$ref = ReadData ("no_such_file.ods");
Expand Down Expand Up @@ -186,6 +185,5 @@ is ($ss->{F1}, "'", "formatted a single '");

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
3 changes: 1 addition & 2 deletions t/411_clr.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_ODS} = "Spreadsheet::ParseODS"; }

my $tests = 266;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -70,4 +69,4 @@ is ($ods->sheet (1)->attr ("C3")->bogus_attr, undef, "C3 bogus attribute OO meth
# Test::NoWarnings::had_no_warnings ();
# $tests++;
# }
done_testing ($tests);
done_testing ();
4 changes: 1 addition & 3 deletions t/412_fmt.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use warnings;

BEGIN { $ENV{SPREADSHEET_READ_ODS} = "Spreadsheet::ParseODS"; }

my $tests = 40;
use Test::More;
require Test::NoWarnings;

Expand Down Expand Up @@ -68,6 +67,5 @@ SKIP: {

unless ($ENV{AUTOMATED_TESTING}) {
Test::NoWarnings::had_no_warnings ();
$tests++;
}
done_testing ($tests);
done_testing ();
Loading