Skip to content

fix: three minor bugs in Context, Filters, and Provider #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddr-bot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: three minor bugs in Context, Filters, and Provider #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de71047
fix: three minor bugs in Context, Filters, and Provider
toddr-bot Apr 3, 2026
2dbc70a
fix: use array access for DEFAULT check on list elements in Stash
toddr-bot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Template/Filters.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,8 @@ sub redirect_filter_factory {
'OUTPUT_PATH is not set'))
unless $outpath;

$context->throw('redirect', "relative filenames are not supported: $file")
if $file =~ m{(^|/)\.\./};
$context->throw('redirect', "path traversal is not permitted: $file")
if $file =~ m{(^|[\\/])\.\.([\\/]|$)};

$options = { binmode => $options } unless ref $options;

Expand Down
36 changes: 36 additions & 0 deletions t/filter.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,3 +981,39 @@ foo(bar)
[% "foo(bar)" | uri %]
-- expect --
foo(bar)

-- test --
-- use evalperl --
[% TRY -%]
[% FILTER redirect('../traversal') %]
should not reach here
[% END -%]
[% CATCH -%]
ERROR [% error.type %]: [% error.info %]
[% END %]
-- expect --
ERROR redirect: path traversal is not permitted: ../traversal

-- test --
-- use evalperl --
[% TRY -%]
[% FILTER redirect('..') %]
should not reach here
[% END -%]
[% CATCH -%]
ERROR [% error.type %]: [% error.info %]
[% END %]
-- expect --
ERROR redirect: path traversal is not permitted: ..

-- test --
-- use evalperl --
[% TRY -%]
[% FILTER redirect('sub/../escape') %]
should not reach here
[% END -%]
[% CATCH -%]
ERROR [% error.type %]: [% error.info %]
[% END %]
-- expect --
ERROR redirect: path traversal is not permitted: sub/../escape
15 changes: 14 additions & 1 deletion t/vars.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ my $params = {
expose => sub { undef $Template::Stash::PRIVATE },
add => sub { $_[0] + $_[1] },

'numlist' => [ 10, 20, 30 ],

# don't define a 'z' - DEFAULT test relies on its non-existance
};

Expand Down Expand Up @@ -463,7 +465,7 @@ bravo

-- test --
[% a = '' b = '' -%]
[% DEFAULT
[% DEFAULT
a = c
b = d
z = r
Expand All @@ -472,6 +474,17 @@ bravo
-- expect --
charlie delta romeo

-- test --
[% DEFAULT numlist.0 = 999 -%]
[% numlist.0 %]
-- expect --
10

-- test --
[% DEFAULT numlist.3 = 40 -%]
[% numlist.3 %]
-- expect --
40

#------------------------------------------------------------------------
# 'global' vars
Expand Down