fix: ttree skips config prompt with --file=FILE (GH #282)#432
Open
toddr-bot wants to merge 3 commits into
Open
fix: ttree skips config prompt with --file=FILE (GH #282)#432toddr-bot wants to merge 3 commits into
toddr-bot wants to merge 3 commits into
Conversation
The offer_create_a_sample_config_file() regex only matched the short -f flag, not --file or --file=FILE. Users specifying a config file via the long option were still prompted to create a default .ttreerc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Recreated from #353 (auto-closed when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ttree --file=FILEno longer prompts to create a default.ttreerc.Why
The config-file prompt guard only matched the short
-fflag. Users passing--file=/path/to/configwere still asked to create a sample rc file,which is confusing and breaks non-interactive usage. Fixes #282.
How
Extended the regex in
offer_create_a_sample_config_file()to also match--fileand--file=...forms.Testing
New
t/ttree_config.tvalidates that both-fand--file=FILEsuppressthe prompt. Verified the test hangs (prompts for STDIN) without the fix.
🤖 Generated with Claude Code