Enable use warnings in Expat.pm and LWPExternEnt.pl#283
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
Expat.pm already has localized 'no warnings "numeric"' in the two namespace methods (namespace() and eq_name()) that call int() on potentially non-numeric strings, so the global pragma is safe. LWPExternEnt.pl had use strict but was missing use warnings entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 76.40% 76.54% +0.14%
==========================================
Files 1 1
Lines 1102 1113 +11
Branches 346 351 +5
==========================================
+ Hits 842 852 +10
Misses 52 52
- Partials 208 209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
use warningstoExpat/Expat.pmandParser/LWPExternEnt.pl.Why
Both files had
use strictbut were missinguse warnings, leaving potential issues (undefined variables, type mismatches) silent. The namespace methods in Expat.pm that callint()on non-numeric strings already have localizedno warnings 'numeric'suppressions, making the global pragma safe.How
Expat/Expat.pm: Replaced the explanatory comment block withuse warnings. Theno warnings 'numeric'at lines 280 and 286 continue to suppress the known int() coercion warnings.Parser/LWPExternEnt.pl: Addeduse warningsafteruse strict.Testing
Full test suite: 725/727 pass. The 2 failures (
load_encoding.ttests 15-16) are pre-existing on main, unrelated to this change.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 2 insertions(+), 3 deletions(-)
Code scan: clean
Tests: failed (17 Failed, 2 tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline