fix: use xml_escape() in Stream.pm instead of manual regex escaping#292
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: use xml_escape() in Stream.pm instead of manual regex escaping#292toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
The Start handler manually applied four regex substitutions to escape XML special characters in attribute values (&, <, >, "). This duplicated the logic in Expat.pm's xml_escape() method. Replace with a single call to $expat->xml_escape($val, '>', '"'), which always escapes & and < and accepts additional characters as arguments. Fixes #280 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 76.40% 76.54% +0.14%
==========================================
Files 1 1
Lines 1102 1113 +11
Branches 346 351 +5
==========================================
+ Hits 842 852 +10
Misses 52 52
- Partials 208 209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stream.pm's
Starthandler manually applied four regex substitutions to escape XML special characters in attribute values, duplicating the logic already available inExpat.pm::xml_escape(). Replaced the four manual regexes with a single$expat->xml_escape($val, '>', '"')call.Fixes #280
Changes
xml_escape()callTest plan
t/stream_attr_escape.tcovers ampersand, quote, and angle bracket escaping in Stream attribute valuesGenerated by Kōan /fix
Quality Report
Changes: 1 file changed, 1 insertion(+), 5 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline