Adding more checks and verbose error message:#1
Open
ocochard wants to merge 1 commit intocperciva:masterfrom
Open
Adding more checks and verbose error message:#1ocochard wants to merge 1 commit intocperciva:masterfrom
ocochard wants to merge 1 commit intocperciva:masterfrom
Conversation
ocochard
commented
Oct 18, 2021
ocochard
commented
- Testing for TSLOG buffer overflow
- Testing for too old loader usage
- Renaming USAGE to README.md to be more github friendly
- Testing for TSLOG buffer overflow - Testing for too old loader usage
cperciva
reviewed
Oct 18, 2021
| echo "No loader timestamp detected, are you using up-to-date loader?" 1>&2 | ||
| exit | ||
| fi | ||
| if [ ! -f tslog.thread.start_init ]; then |
Owner
There was a problem hiding this comment.
A better check would be for tsc.end existing -- if we have 'ENTER start_init' but the tslog buffer is truncated before 'EXIT start_init' then we'll have tslog.thread.start_init but not tsc.end.
cperciva
reviewed
Oct 18, 2021
| echo "$TD $TSC STACK $STACK" | ||
| done > tslog.thread.$THREAD | ||
| done < threads | ||
| if [ ! -f tslog.thread.0x0 ]; then |
Owner
There was a problem hiding this comment.
We could handle this case by processing what we have (i.e. kernel tslog). It wouldn't give us a complete picture of the boot process, but might still be better than nothing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.