[5.x] Error when marking inventory transfer as pending#4272
Open
nfourtythree wants to merge 4 commits into5.xfrom
Open
[5.x] Error when marking inventory transfer as pending#4272nfourtythree wants to merge 4 commits into5.xfrom
nfourtythree wants to merge 4 commits into5.xfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a type mismatch that triggers a PHP TypeError when an Inventory Transfer is moved from Draft → Pending by ensuring the inventory update model used during transfers is compatible with the UpdateInventoryLevelEvent payload type.
Changes:
- Updated
UpdateInventoryLevelInTransferto inherit fromUpdateInventoryLevel(so it can be assigned toUpdateInventoryLevelEvent::$updateInventoryLevel). - Attempted to narrow
UpdateInventoryLevelInTransfervalidation rules to only allow incoming/onHand transaction types. - Added an Unreleased changelog entry referencing the fix and issue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/models/inventory/UpdateInventoryLevelInTransfer.php |
Makes transfer inventory updates extend the base update model and customizes validation rules. |
CHANGELOG.md |
Documents the fix in the Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#4267