Skip to content

Feat: Add support for Bosch with temperature float value#2068

Open
zhixuan2333 wants to merge 7 commits into
crankyoldgit:masterfrom
zhixuan2333:feat-bosch-temp-decimals
Open

Feat: Add support for Bosch with temperature float value#2068
zhixuan2333 wants to merge 7 commits into
crankyoldgit:masterfrom
zhixuan2333:feat-bosch-temp-decimals

Conversation

@zhixuan2333

@zhixuan2333 zhixuan2333 commented Feb 19, 2024

Copy link
Copy Markdown

@crankyoldgit crankyoldgit self-requested a review February 19, 2024 05:22

@crankyoldgit crankyoldgit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for taking the time and effort to improve the library.
Appologies for all the suggestions/questions.

Can you please also provide some state[] corresponding to the 0.5deg additions so we can add some unit tests to verify and check the code against known-good data?

Comment thread src/ir_Bosch.cpp
Comment thread src/ir_Bosch.cpp
Comment thread src/ir_Bosch.cpp
Comment thread src/ir_Bosch.cpp Outdated
Comment thread src/ir_Bosch.h Outdated
Comment thread src/ir_Bosch.h Outdated
@zhixuan2333

zhixuan2333 commented Feb 19, 2024

Copy link
Copy Markdown
Author

Can you please also provide some state[] corresponding to the 0.5deg additions so we can add some unit tests to verify and check the code against known-good data?

Mode Hex
Cool/16.0 0xC23DBF4000FFC23DBF4000FFD5660010004B
Cool/19.0 0xC23DBF4030CFC23DBF4030CFD5660000003B
Cool/19.5 0xC23DBF4030CFC23DBF4030CFD5662000005B
Cool/20.0 0xC23DBF4020DFC23DBF4020DFD5660000003B
Cool/20.5 0xC23DBF4020DFC23DBF4020DFD5662000005B
Cool/21.0 0xC23DBF40609FC23DBF40609FD5660000003B
Cool/21.5 0xC23DBF40609FC23DBF40609FD5662000005B
Cool/22.0 0xC23DBF40708FC23DBF40708FD5660000003B
Cool/30.0 0xC23DBF40B04FC23DBF40B04FD5660000003B

and also here.
https://docs.google.com/spreadsheets/d/1gf2wcYWTul5B5qxhGLA25nAKQwmfrvwjtUM3SG4Ty9M/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants