Add support for Arduino ESP32 core v3.x - IDF v5.x#2215
Closed
macca448 wants to merge 15 commits into
Closed
Conversation
Doxygen docs update for v2.8.7
Collaborator
NiKiZe
requested changes
Jul 31, 2025
NiKiZe
left a comment
Collaborator
There was a problem hiding this comment.
Remove changes of version and doc updates from git history and force push, those changes are only done in the release process.
Author
|
2 fails now |
Collaborator
|
Don't close PRs, fix the commits and force-push. |
Author
|
Sorry I mistakenly took a link supplied by one of your collogues too literal and didn't see it was just for reference. I obviously broke something in my attempt to fix as you requested and nothing would update. Won't bother you ever again but if you're interested I've published the patch I made that adds ESP32 Arduino Core V3.x functionality to IRremoteESP8266 (v2.8.6) here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches the IRremoteESP8266 library for compatibility with the updated Arduino ESP32 Core v3.x timer API which will address the feature request #2039
Key changes:
timerBegin()/timerAlarmEnable()usage with new APIlibrary.propertiesto reflect version2.8.7Notes:
This PR is intended to maintain backward compatibility while ensuring ESP32 users can continue using the library after upgrading the core. The fork will remain maintained until upstream merges this patch.
Hardware Testing
IRrecvDumpV2.inoexample I compiled and uploaded to a ESP-WROOM-32 based dev with a TSOP4136 attached and tested IR capture. Proved working by multiple captures of the same button. Works well and no issues found.IRrecvDumpV2.inowith both Arduino IDE v1.8.19 and the current v2.3.6 using both Arduino ESP32 core v2.0.17 and current v3.3.0. No errors or warning.Compile Checks
IRrecvDumpV2.inocompiled selecting the genericESP8266to confirm nothing broken. No errors reported.ESP32S3. No errors but two (2) benign warnings not related to the IRremoteESP8266 library.ESP8266. No errors and one JSON warning that should disappear when ArduinoJson V8.x is released.A long overdue patch, hopefully this PR meets with your approval
— macca-nz / macca448