Open
Conversation
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
If the cellular network is in service, and the data network name is not available for some reason, rather than falling back to the default network name of "No service", use the carrier name. Issue: calyxos#2256 Change-Id: Ibf02f67b70cfc5d4804e9d6a3f53a9d112811d1d Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
…ith lower version sdks The applications compiled with lower version sdks can not request audio focus properly in some scenes, which will cause many anomalies. Change-Id: I8875922efdfbcd08a7872e090c3c4b51446b2637 Signed-off-by: wumin3 <wumin3@xiaomi.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
When the user cycles fast between modes the last toast will show so late it'll be irrelevant Change-Id: I0f8f442ea10d670663fdd298f2198f6e8baa7a36 Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Avoid it getting cut off at bottom on devices with low udfps, where the bottom margin is lesser. Change-Id: I2ce00abeba353fff4cb4aa8a58257ef54bf4cca9 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Saw some users complaining about that and I personally don't see much point of it. Change-Id: I5b9fe7e4a4f14b231533cd9e295a03bfb852a9b3 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
onUserStopped() method name was misleading, it's called from onUserStopping(), while the user is still running. Initial research was done by maade93791 <70593890+maade69@users.noreply.github.com> Co-authored-by: maade93791 <70593890+maade69@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
summary：(Animator$AnimatorCaller$$ExternalSyntheticLambda1.call)java.lang.NullPointerException--Attempt to invoke interface method 'void android.animation.Animator$AnimatorListener.onAnimationEnd(android.animation.Animator, boolean)' on a null object reference det：versionName:20240724.0, versionCode:202407240 java.lang.NullPointerException: Attempt to invoke interface method 'void android.animation.Animator$AnimatorListener.onAnimationEnd(android.animation.Animator, boolean)' on a null object reference at android.animation.Animator$AnimatorCaller$$ExternalSyntheticLambda1.call(D8$$SyntheticClass:0) at android.animation.Animator.callOnList(Animator.java:666) at android.animation.Animator.notifyListeners(Animator.java:609) at android.animation.Animator.notifyEndListeners(Animator.java:634) at android.animation.ValueAnimator.endAnimation(ValueAnimator.java:1306) at android.animation.ValueAnimator.doAnimationFrame(ValueAnimator.java:1566) at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344) at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0) at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87) at android.view.Choreographer$CallbackRecord.ru Test:UAT Change-Id: I135eac97787a6d3b820a2336908bf1412d2ed218 Signed-off-by: xiangshuangxi <xiangshuangxi@xiaomi.com>
* Space is too small. It often overlaps with face unlock image. * Tweak space above clock and above notifications. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
… main thread time During the notification bar case fluency test in the system core UI scene, the SystemUIUi main thread experienced severe frame drops due to frequent execution of the following DateTimeView logic while updating the status bar time once a minute: android.view.ViewRootImpl$ViewRootHandler: android.widget.DateTimeView$ReceiverInfo$$ExternalSyntheticLambda0 Signed-off-by: Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com> Change-Id: I888218897555d596b46b78f23a63d1df1750b3ca
Inspired by nothing ;) Shrink down the dialog a bit to make way for it. [neobuddy89: Adapted for A15.] [Arman-ATI: Adapted for A16.] [neobuddy89: Improvised for A16.] Change-Id: I56b8c70011c90103e87ee298d83d9f93270d8bc5 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Dmitrii <bankersenator@gmail.com>
Most of time, 5G is still considered too power hungry compared to the improvement of network speed. Provide users with a quick and convenient way to toggle this function so that it can only be used when needed. AngelaCooljx: Port to Android14 QPR1 R15Hi: port to Android14 QPR3 neobuddy89: Layout fixes for 5G toggle, add missing code bits Arman-ATI: Adapted for A16 neobuddy89: Improvised for A16 Change-Id: Ieee71904220e2d472d31045ca926b5c854299eed Signed-off-by: LibXZR <i@xzr.moe> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Dmitrii <bankersenator@gmail.com>
Change-Id: I424f5aca2b3c0799b9e89a10ced3b40ae6dfd57e Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ib9420f5fb7dd0f249c6703a60b151b78fd6a5c24 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This reverts commit 6fcdb6b. Change-Id: I125d2aff9b406341a533cbfe80686ee473dd3e88 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
...after using actions such as "delete" or "share". Post / Recieve the notification ID with the intent for that. Also count grouped notifications to decide when to dismiss the group summary and only close QS after all notifications are dismissed. Change-Id: I1023367412b2b737b1cf3e9935b1d268059a2a3d Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Also remove some unused components. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Previously we played only when ringer mode was set to vibrate. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Root Cause: The function convertAudioGainConfigToNative forgets to call ReleaseIntArrayElements to release memory after calling GetIntArrayElements. Bug: 444915885 Test: atest Co-authored-by: Zheng Xiaoying <zheng.xiaoying@gm.com> Change-Id: Ifa323280d744cb82ae6ae648f04aa31000c5ba06
Add null check for string parameter in writeUTF() method to prevent NullPointerException when attempting to call length() on null string. This fixes a security vulnerability where entering "adb shell service call notification 28" would cause system process crash and phone reboot due to unhandled null string parameter. Bug: Security vulnerability in Android 14 Test: Verified no crash when writeUTF() receives null parameter Change-Id: If9dc9ab2b3aefd84f93c603300c0cee69d93a4b7
[Details]: Change SaveUi dialog gravity from BOTTOM | CENTER to CENTER to prevent the dialog from overlapping with the system navigation bar. This ensures the dialog will not be covered in any scenario. Test: run cts -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.SessionLifecycleTest#testDatasetAuthResponseWhileAutofilledAppIsLifecycled Signed-off-by: ezra hu <ezra.hu@mediatek.com> Change-Id: I769e58b55caa3edd78dcf410017d023fda0dcde6
Bug: none Flag: EXEMPT minor optimization Change-Id: I234ddd6e7ce628eb54448dc1d8bc994d678aaccb
JavaBinder: *** Uncaught remote exception! Exceptions are not yet supported across processes. Client PID 20178 UID 10146. JavaBinder: java.util.NoSuchElementException: Death link does not exist (NAME_NOT_FOUND) JavaBinder: at android.os.BinderProxy.unlinkToDeathNative(Native Method) JavaBinder: at android.os.BinderProxy.unlinkToDeath(BinderProxy.java:749) JavaBinder: at com.android.server.wm.InputConsumerImpl.unlinkFromDeathRecipient(InputConsumerImpl.java:105) JavaBinder: at com.android.server.wm.InputConsumerImpl.disposeChannelsLw(InputConsumerImpl.java:151) JavaBinder: at com.android.server.wm.InputMonitor.destroyInputConsumer(InputMonitor.java:189) JavaBinder: at com.android.server.wm.WindowManagerService.destroyInputConsumer(WindowManagerService.java:7494) JavaBinder: at android.view.IWindowManager$Stub.onTransact(IWindowManager.java:3071) JavaBinder: at com.android.server.wm.WindowManagerService.onTransact(WindowManagerService.java:1810) JavaBinder: at android.os.Binder.execTransactInternal(Binder.java:1433) JavaBinder: at android.os.Binder.execTransact(Binder.java:1372) AndroidRuntime: java.lang.IllegalStateException: Invalid usage after release of Surface(name=Input Consumer recents_animation_input_consumer#368691)/@0x64f6925 AndroidRuntime: at android.view.SurfaceControl.checkNotReleased(SurfaceControl.java:2101) AndroidRuntime: at android.view.SurfaceControl.-$$Nest$mcheckNotReleased(Unknown Source:0) AndroidRuntime: at android.view.SurfaceControl$Transaction.checkPreconditions(SurfaceControl.java:3497) AndroidRuntime: at android.view.SurfaceControl$Transaction.hide(SurfaceControl.java:3764) AndroidRuntime: at com.android.server.wm.InputConsumerImpl.hide(InputConsumerImpl.java:128) AndroidRuntime: at com.android.server.wm.InputMonitor.resetInputConsumers(InputMonitor.java:230) AndroidRuntime: at com.android.server.wm.InputMonitor$UpdateInputForAllWindowsConsumer.updateInputWindows(InputMonitor.java:671) AndroidRuntime: at com.android.server.wm.InputMonitor$UpdateInputForAllWindowsConsumer.-$$Nest$mupdateInputWindows(Unknown Source:0) AndroidRuntime: at com.android.server.wm.InputMonitor$UpdateInputWindows.run(InputMonitor.java:150) AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:995) AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:103) AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:265) AndroidRuntime: at android.os.Looper.loop(Looper.java:358) AndroidRuntime: at android.os.HandlerThread.run(HandlerThread.java:85) AndroidRuntime: at com.android.server.ServiceThread.run(ServiceThread.java:49) AndroidRuntime: Caused by: java.lang.Throwable: Released AndroidRuntime: at android.view.SurfaceControl.release(SurfaceControl.java:2048) AndroidRuntime: at android.view.SurfaceControl$Transaction.remove(SurfaceControl.java:5883) AndroidRuntime: at com.android.server.wm.InputConsumerImpl.disposeChannelsLw(InputConsumerImpl.java:150) AndroidRuntime: at com.android.server.wm.InputMonitor.destroyInputConsumer(InputMonitor.java:189) AndroidRuntime: at com.android.server.wm.WindowManagerService.destroyInputConsumer(WindowManagerService.java:7494) AndroidRuntime: at android.view.IWindowManager$Stub.onTransact(IWindowManager.java:3071) AndroidRuntime: at com.android.server.wm.WindowManagerService.onTransact(WindowManagerService.java:1810) AndroidRuntime: at android.os.Binder.execTransactInternal(Binder.java:1433) AndroidRuntime: at android.os.Binder.execTransact(Binder.java:1372) Bug:447782737 Test:Manual Change-Id: I4fd6d94f960b61429720a83b81f76976f2782676 Signed-off-by: huyuxin <huyuxin@xiaomi.com>
Avoids ANRs and excessive I/O by delaying the system APK summary scan, which was previously triggered inappropriately during the boot phase. The scan will now initiate 1 minute after boot if triggered within the initial 30 seconds. Test: test steps are: 1.Install 60 APKs; All Logs, Data filled to 95%; 2.Close watchdog, open Sysdump; 3.Repeated restart for a long time (120h) Bug: 414507692 Change-Id: I1d329484ac12d4763248bd9c650d15e8741aea5d
Language Settings crashing due to ConcurrentModificationException. The structure of the map used for supportedLocaleInfos is being changed while it's being read. One way to fix this is by creating a copy of map for iteration. bug: 420412904 Change-Id: Ideb02ac913f474edec5bb437574fb6da94344d0f
Change-Id: Ic7ba1db1a0845242cecb55e6012bf56f4329a30d Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Test: * Press power button for power menu and then dismiss it * Change UI mode * Press power button again - it should colors matching new UI mode Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Not sure where this is failing for main thread check. * Let's remove assert check for dump function. Log: time: 1761829105393 msg: java.lang.IllegalStateException: should be called from the main thread. sMainLooper.threadName=main Thread.currentThread()=dump-thread stacktrace: java.lang.IllegalStateException: should be called from the main thread. sMainLooper.threadName=main Thread.currentThread()=dump-thread at com.android.systemui.util.Assert.isMainThread(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:60) at com.android.systemui.statusbar.notification.collection.NotifCollection.dump(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:3) at com.android.systemui.dump.DumpHandler$Companion.dumpDumpable(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:21) at com.android.systemui.dump.DumpHandler.dumpCritical(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:31) at com.android.systemui.dump.DumpHandler.dump(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:8) at com.android.systemui.SystemUIService.dump(go/retraceme a0ed5d08cbafd6ceda3025e7580143a234574b99d67372ec0a205b5910abeaab:19) at android.app.ActivityThread.handleDumpService(ActivityThread.java:5389) at android.app.ActivityThread.-$$Nest$mhandleDumpService(Unknown Source:0) at android.app.ActivityThread$ApplicationThread.lambda$dumpService$0(ActivityThread.java:1521) at android.app.ActivityThread$ApplicationThread.$r8$lambda$OeHpPo9a5q6Dn6gB6isOwWv_X-E(Unknown Source:0) at android.app.ActivityThread$ApplicationThread$$ExternalSyntheticLambda8.run(D8$$SyntheticClass:0) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651) at java.lang.Thread.run(Thread.java:1119) Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Fixes: crdroidandroid/issue_tracker#822 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
The possible execution order of the code is on the UI thread: 1 Firstly,we post the delay mDelegationIdleTimeoutRunnable into the UiHandler. 2 Secondly,the onInputEvent method is caaled,so the mRecordingGesture or mRecordingGestureAfterStylusUp is true. 3 mDelegationIdleTimeoutRunnable is Executed due to timeout,so the mHandwritingBuffer is empty. 4 Finally,startHandwritingSession method is called,we call the get method of mHandwritingBuffer which is empty,so IndexOutOfBoundsException happen. we should reset the the mRecordingGesture and mRecordingGestureAfterStylusUp value to false when timeout happen. Bug: 459595388 Flag: bugfix Change-Id: I28002bb90322db8d40a4c55d9102521def9cf52a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.