Open
Conversation
…inates retry jitter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There needs to be a way to eliminate retry jitter. For my use case, I need the autobahn client to attempt to reconnect to a server every 2 seconds. With the pseudo-random retry times introduced by the jitter, my retry time can end up anywhere from a few milliseconds to 30 seconds (depending on how long I leave it). That's not ideal for me.
The code already has a clause that only applies retry jitter if the
_retry_delay_jitterproperty is truthy. So if the property were 0, then no retry jitter would be applied.However, due to the way
self._retry_delay_jitteris initialized, it will never accept a value of 0. This pull request changes that and allowsself._retry_delay_jitterto be set to 0.