Fix 89 - #220
Merged
Merged
Conversation
…rio#89) On the asyncio backend, _log() did `getattr(logger._logger, level)(msg)` with level == "warn", which resolves to logging.Logger.warn — the deprecated alias of .warning — emitting "DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead". Remap the "warn" level name to "warning" for stdlib dispatch, mirroring the existing "trace" -> "debug" handling, while keeping the txaio-facing level name "warn" in kwargs["log_level"]. The Twisted backend is unaffected (it maps to LogLevel.warn, not stdlib method names). Add a cross-backend regression test (test_warn) that turns DeprecationWarning into an error and asserts the message is emitted. Verified red before the fix (asyncio) and green after, both backends. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #89