feat(elasticache): support inplace migration to valkey engine - #2293
feat(elasticache): support inplace migration to valkey engine#2293Kunalbehbud wants to merge 2 commits into
Conversation
|
Leaving a ping here in case this fell through the cracks. Happy to adjust the Valkey migration behavior or test coverage if there are concerns. |
ridik-il
left a comment
There was a problem hiding this comment.
Thanks @Kunalbehbud — clean, well-scoped change and I appreciate the thorough test coverage (the dedicated Update test asserting Engine reaches ModifyReplicationGroup is exactly right, and updating all the cacheClusterNeedsUpdate fixtures was the correct call). I verified the whole provider builds against the bumped SDK and all elasticache tests pass, and confirmed removing +immutable is safe (it was advisory — no webhook/test enforced it — and engine is required so existing resources are unaffected). One thing to fix before merge: go.sum isn't tidy (go mod tidy drops 20 stale lines, including hashes for versions newer than what go.mod pins) — please run go mod tidy and commit. Optionally, consider an Enum=redis;valkey validation on the now-mutable engine field and a doc note that only redis→valkey migration is supported. Happy to approve once go.sum is sorted.
Signed-off-by: Kunalbehbud <b.kunal2002@gmail.com>
21a8256 to
1ed89a3
Compare
|
Rebased onto |
- Only report an Engine change when one is explicitly requested, so an unset engine is not treated as drift (the resource would otherwise never be up to date). - Set Engine on the cache-cluster fixtures and initialize the external cache in the Update test, both broken by the merge with the log delivery changes. - go mod tidy to drop stale go.sum entries. Signed-off-by: Kunalbehbud <b.kunal2002@gmail.com>
Fixes #2290
This PR adds support for in-place ElastiCache ReplicationGroup migration from Redis to Valkey.
It makes
spec.forProvider.enginemutable, updates the ElastiCache client logic to passEnginethroughModifyReplicationGroupInput, and extends update detection so engine changes are reconciled correctly. It also updates the AWS SDK dependency to a version that exposes the ElastiCache Valkey support needed by this flow.Checklist
ModifyReplicationGroupInputincludesEnginemake testsuccessfully