Skip to content

Sync realm roles from Keycloak in admin service #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iammajid wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Sync realm roles from Keycloak in admin service #423

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5ffea1
sync realm roles in KeycloakAdminService.syncUser()
iammajid Mar 10, 2026
0939e59
read back effective roles from Keycloak after role update
iammajid Mar 16, 2026
666d321
restore db-first ordering in updateUserRoles
iammajid Mar 18, 2026
87375f4
use direct role assignments instead of effective roles
iammajid Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions backend/src/main/java/org/cryptomator/hub/keycloak/KeycloakAdminService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.keycloak.admin.client.resource.UserResource;
import org.keycloak.representations.idm.CredentialRepresentation;
import org.keycloak.representations.idm.GroupRepresentation;
import org.keycloak.representations.idm.RoleRepresentation;
import org.keycloak.representations.idm.UserRepresentation;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -204,6 +205,10 @@ public User syncUser(String userId) {
dbUser.setEmail(keycloakUser.getEmail());
dbUser.setFirstName(keycloakUser.getFirstName());
dbUser.setLastName(keycloakUser.getLastName());
var kcRoleNames = userResource.roles().realmLevel().listEffective().stream()
.map(RoleRepresentation::getName)
.toList();
dbUser.setRealmRoles(RealmRole.fromKcNames(kcRoleNames).stream().map(RealmRole::kcName).toArray(String[]::new));

var attrs = keycloakUser.getAttributes();
if (attrs != null && attrs.containsKey("picture")) {
Expand Down Expand Up @@ -283,12 +288,7 @@ public void updateUserRoles(String userId, Set<RealmRole> roles) {
var rolesToSet = EnumSet.noneOf(RealmRole.class);
rolesToSet.addAll(roles);

// 1. sync to db (roll back if kc update fails):
User dbUser = userRepo.findByIdOptional(userId).orElseThrow(NotFoundException::new);
dbUser.setRealmRoles(rolesToSet.stream().map(RealmRole::kcName).toArray(String[]::new));
userRepo.persist(dbUser);

// 2. sync to kc:
// 1. sync to kc:
UserResource userResource = realm.users().get(userId);
var roleMappings = userResource.roles().realmLevel();
if (!rolesToRemove.isEmpty()) {
Expand All @@ -297,6 +297,14 @@ public void updateUserRoles(String userId, Set<RealmRole> roles) {
if (!rolesToSet.isEmpty()) {
roleMappings.add(rolesToSet.stream().map(realmRoles::getRealmRole).toList());
}

// 2. sync effective roles from kc to db:
User dbUser = userRepo.findByIdOptional(userId).orElseThrow(NotFoundException::new);
var kcRoleNames = roleMappings.listEffective().stream()
.map(RoleRepresentation::getName)
.toList();
dbUser.setRealmRoles(RealmRole.fromKcNames(kcRoleNames).stream().map(RealmRole::kcName).toArray(String[]::new));
userRepo.persist(dbUser);
}

// Group management methods
Expand Down
Loading