Truncate long names in detail cards and breadcrumbs#437
Truncate long names in detail cards and breadcrumbs#437
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis pull request adds text truncation and tooltip enhancements across three Vue components. BreadcrumbNav.vue and GroupInfo.vue each receive a single-line modification to add Tailwind Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| {{ displayName }} | ||
| </h2> | ||
| <p v-if="user.firstName || user.lastName" class="text-sm text-gray-500 mt-1"> | ||
| <p v-if="user.firstName || user.lastName" class="text-sm text-gray-500 mt-1 truncate w-full" :title="user.name"> |
There was a problem hiding this comment.
the v-if seems misplaced here
There was a problem hiding this comment.
Should the condition be v-if="displayName !== user.name" instead, so it relies on the computed property rather than duplicating its logic?
There was a problem hiding this comment.
that should make it more clear, yes
Summary
displayNamecomputed property in UserInfo for cleaner template logic