feat(context): add LoginRequired reason for silent SSO failure detection#53
Open
loispostula wants to merge 1 commit intoctron:mainfrom
Open
feat(context): add LoginRequired reason for silent SSO failure detection#53loispostula wants to merge 1 commit intoctron:mainfrom
loispostula wants to merge 1 commit intoctron:mainfrom
Conversation
Owner
|
Thanks for the PR. I'm trying to understand the motivation behind the change. If this error is being reported, the user should be (gracefully) told to login. Is that correct? And the idea is to treat that state as "not authenticated", adding a specific reason (in cases where this would help the application)? Right? |
Contributor
Author
|
That's correct, my use case with this, is that i perform a silent login, ( |
ctron
approved these changes
Feb 5, 2026
Owner
ctron
left a comment
ctron
left a comment
There was a problem hiding this comment.
LGTM. Although this is a breaking change. Which is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.