fix(tracing): classify durable HITL pauses and gate raw diagnostics - #207
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
@codex review |
xfgong
self-requested a review
August 4, 2026 02:06
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
xfgong
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suspendedinstead of treating a valid pause as an aborted runrecord_content=TrueWhy
A durable HITL activation ends with
AgentSuspendedEvent, notAgentEndEvent. The recorder previously ignored that event, so the required detach cleanup closed the still-open spans ascubepi.aborted=true. A valid pause was therefore indistinguishable from cancellation.Separately, several error paths could retain raw provider/tool diagnostics even when the tracer was constructed with
record_content=False. That made the privacy switch incomplete.Behavior
cubepi.run.outcome=suspendedand are not marked abortedrecord_content=Falseretains operational IDs, enums, model/tool names, counts, timings, token usage, and typed error classes, but excludes raw messages, arguments/results, provider descriptions, exception messages, and stack tracesrecord_stream=Falsecontinues to disable raw stream filesValidation
tests/tracing: 224 passedCommits
5e51086— durable HITL pauses are suspended, not aborted550f56f— provider/turn raw errors follow content opt-in019a261— MCP/one-shot/stream diagnostics follow content opt-in