test: add coverage for follow-up messages and stream fallback - #56
Merged
Conversation
…stream fallback Cover previously uncovered lines in agent/loop.py: - Lines 238-244: follow-up messages callback triggers additional turns - Line 266: async convert_to_llm coroutine is properly awaited - Lines 328-335: fallback path when stream ends without done/error event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_follow_up_messagescallback (lines 238-244): verifies follow-up messages are injected after the inner loop completes and trigger an additional assistant turnconvert_to_llm(line 266): verifies coroutine-returning converters are properly awaiteddoneorerrorevent, covering both theadded_partial=Trueandadded_partial=FalsebranchesCloses #48
Test plan
pytest tests/ -q --ignore=tests/checkpointer-- 293 passed (4 new)ruff check cubepi/ tests/-- all checks passedruff format --check cubepi/ tests/-- all formatted