add a target mostlyclean in Makefiles#395
Merged
mpkorstanje merged 3 commits intocucumber:mainfrom May 19, 2025
Merged
Conversation
mpkorstanje
reviewed
May 15, 2025
| .PHONY: clean-gherkin-languages | ||
|
|
||
| clean: clean-deps ## Remove all build artifacts and files generated by the acceptance tests | ||
| mostlyclean: |
Contributor
There was a problem hiding this comment.
Does this need a documentation string for make help?
Contributor
Author
There was a problem hiding this comment.
I don't think.
But alternately, I push a 3rd commit with an update of CONTRIBUTING.md
Contributor
|
Cheers! LGTM, small remark above |
mpkorstanje
reviewed
May 18, 2025
| mostlyclean: | ||
| rm -rf .compared .built .run acceptance | ||
| $(MAKE) --directory=src $@ | ||
| $(MAKE) --directory=src clean |
Contributor
There was a problem hiding this comment.
Not every makefile further down has a mostlyclean, fixed it like this, but not sure if that is what you intended.
Contributor
Author
|
rebased with your fix in |
Contributor
|
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Add a new target
mostlycleanwhich differs fromcleanby not removing the external dependencies.mostlycleanis a well known name for a target, see https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html.⚡️ What's your motivation?
Speed up the development process with the mantra
make mostlyclean acceptance(external dependencies are seen as stable)
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.