Markdown support for Perl

[fperrad]

🤔 What's changed?

Adding Markdown with Gherkin (MDG) support for Perl.

⚡️ What's your motivation?

🏷️ What kind of change is this?

• ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Javascript is the reference implementation for MDG, but it lacks the gherkin-generate-tokens (and the corresponding tests).

So, I am not confident with the test suite.

Some points need clarification:

• with MDG, the messages Comment are skipped when building the AST : bug or feature ? (feature)

• I try to reuse testdata/good/*.feature.md.tokens from Markdown support for java #377, but there need some changes. So, these files need a review / validation.

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[mpkorstanje]

with MDG, the messages Comment are skipped when building the AST : bug or feature ?

I'm not sure if I understand this. I don't think Markdown supports comments. What would a comment in Markdown look like?

Javascript is the reference implementation for MDG, but it lacks the gherkin-generate-tokens (and the corresponding tests).

Would you be able to add the functionality to generate tokens to the JS implementation?

[mpkorstanje]

I've given this a once over. Other than my remark on the AST builder I don't see anything too odd. But this PR also exceeds my current capacity for in-depth review.

@ehuelsmann would you be so kind?

[fperrad]

Would you be able to add the functionality to generate tokens to the JS implementation?

sorry, I can't.

[fperrad]

rebased, and the commit "[Perl] don't populate comments in AST when MDG" was replaced by "[Perl] ignore Comment in AST"

[ehuelsmann]

Yes. This is now the equivalent of the JS code. Very good.

While you were heads down implementing this MD support, the project received and fixed #400. Based on my review of the JS code and this PR both are lacking the required fix. Please add the fix and I'll PR for JS. [Edit: I reviewed main and came to the conclusion that it's actually there, but apparently not where I was looking for it.]

[ehuelsmann]

I approve of the current state.

[ehuelsmann]

@fperrad out of curiosity, where does your interest in contributing GherkinInMarkdown from? Are you planning to use this Perl implementation yourself?

[ehuelsmann]

@mpkorstanje lets wait a few days for the Python implementation to be ready for merging too. Then we can release both in a single release.

[mpkorstanje]

I would say that more than a few days have passed. 😉