Skip to content

javascript: Prefer the longest keywords#407

Merged
mpkorstanje merged 4 commits intomainfrom
prefer-longest-step-keyword-js
May 25, 2025
Merged

javascript: Prefer the longest keywords#407
mpkorstanje merged 4 commits intomainfrom
prefer-longest-step-keyword-js

Conversation

@davidjgoss
Copy link
Copy Markdown
Member

@davidjgoss davidjgoss commented May 25, 2025

🤔 What's changed?

When matching steps to keyword, sort in descending order of length, so long keywords are preferred over shorter subsets.

⚡️ What's your motivation?

JavaScript part of #400.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss force-pushed the prefer-longest-step-keyword-js branch from 0a15427 to 05799ba Compare May 25, 2025 13:53
@davidjgoss davidjgoss marked this pull request as ready for review May 25, 2025 13:56
@davidjgoss davidjgoss requested a review from mpkorstanje May 25, 2025 13:57
@davidjgoss davidjgoss force-pushed the prefer-longest-step-keyword-js branch from dc1e086 to 9389858 Compare May 25, 2025 13:58
@mpkorstanje mpkorstanje changed the title Prefer longest step keyword in JavaScript javascript Prefer the longest keywords #404 May 25, 2025
@mpkorstanje mpkorstanje changed the title javascript Prefer the longest keywords #404 javascript: Prefer the longest keywords #404 May 25, 2025
@mpkorstanje mpkorstanje changed the title javascript: Prefer the longest keywords #404 javascript: Prefer the longest keywords May 25, 2025
@mpkorstanje mpkorstanje merged commit 38970e0 into main May 25, 2025
7 checks passed
@mpkorstanje mpkorstanje deleted the prefer-longest-step-keyword-js branch May 25, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants