Skip to content

[Perl] Prefer the longest step keyword#408

Merged
mpkorstanje merged 8 commits intomainfrom
prefer-longest-step-keyword-perl
May 25, 2025
Merged

[Perl] Prefer the longest step keyword#408
mpkorstanje merged 8 commits intomainfrom
prefer-longest-step-keyword-perl

Conversation

@ehuelsmann
Copy link
Copy Markdown
Contributor

@ehuelsmann ehuelsmann commented May 25, 2025

🤔 What's changed?

Address the issue reported in #400 (Gherkin should prefer the longest prefix match on step keywords).

⚡️ What's your motivation?

Advance all Gherkin implementations at the same time, including Perl.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@ehuelsmann ehuelsmann force-pushed the prefer-longest-step-keyword-perl branch from 3c184ed to 3a795a8 Compare May 25, 2025 13:47
@ehuelsmann ehuelsmann changed the title Prefer the longest step keyword in Perl [Perl] Prefer the longest step keyword May 25, 2025
Copy link
Copy Markdown
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more commits than I would expect in this pull request.

@ehuelsmann
Copy link
Copy Markdown
Contributor Author

There are more commits than I would expect in this pull request.

I started out with fix/prefer-longest-step-keyword; originally there was only 1 commit (starting from "main"), but when I rebased, the extra commits came in. I'll be happy to put it back on "main" if that's the better option. I'll also address the performance review remark.

@ehuelsmann ehuelsmann force-pushed the prefer-longest-step-keyword-perl branch from 3a795a8 to df41bee Compare May 25, 2025 14:00
@mpkorstanje
Copy link
Copy Markdown
Contributor

I started out with fix/prefer-longest-step-keyword; originally there was only 1 commit (starting from "main"), but when I rebased, the extra commits came in. I'll be happy to put it back on "main" if that's the better option. I'll also address the performance review remark.

Cheers!

The test data will be merged separately. Otherwise the build will fail for all implementations.

@mpkorstanje mpkorstanje merged commit e1d8cd8 into main May 25, 2025
3 checks passed
@mpkorstanje mpkorstanje deleted the prefer-longest-step-keyword-perl branch May 25, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants