Merged
Conversation
This was referenced Jun 17, 2025
* Adds cpp to the root make file so the parser updated with `make generate` * Regenerate cpp parser * Fix #333 for cpp
a044ed1 to
485816d
Compare
Contributor
Author
7 tasks
Contributor
Contributor
|
The (first) failing acceptance test in this case is: which is exactly the example in #414. |
Contributor
Author
|
Thanks for the quick PR. We can fix this in small steps. I'll check/merge tomorrow. To further fix things, in general terms, in the implementation there should be a The solutions to #400 might provide some inspiration. But I'm on my phone right now so that's all I can usefully contribute for today. |
7 tasks
Contributor
|
I’ve managed to fix the last acceptance test failure in #416. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
make generate⚡️ What's your motivation?
Investigate #412
Resolve #333 for cpp.
🏷️ What kind of change is this?
📋 Checklist: