Closed
Conversation
mpkorstanje
force-pushed
the
extended-whitespace-in-tags
branch
from
cf86b19 to
e549f10
Compare
mpkorstanje
force-pushed
the
extended-whitespace-in-tags
branch
from
0b05ca4 to
733f828
Compare
mpkorstanje
added a commit
that referenced
this pull request
Jul 27, 2025
While investigating the impact of #436 and #438 some discrepancies came to light. Lines consisting entirely of whitespace are considered empty. As such the tokens for these lines should have 0 indentation and start at column 1. This behavior diverged for c, .net, go, java and php. As tokens are not part of the public API, this change has no impact on the observable behavior of the parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
Validate findings from #436 against other implementations.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: