java: Add explicit property names to constructor arguments #399
Draft
mpkorstanje wants to merge 2 commits intomainfrom
Draft
java: Add explicit property names to constructor arguments #399mpkorstanje wants to merge 2 commits intomainfrom
mpkorstanje wants to merge 2 commits intomainfrom
Conversation
mpkorstanje
added a commit
to cucumber/messages-ndjson
that referenced
this pull request
Apr 6, 2026
7 tasks
mpkorstanje
added a commit
to cucumber/messages-ndjson
that referenced
this pull request
Apr 6, 2026
mpkorstanje
added a commit
to cucumber/messages-cli
that referenced
this pull request
Apr 6, 2026
Deserialize using explicitly defined property names utilizing cucumber/messages#399. Closes: #50
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
To de-serialize messages a deserializer has to know what order the fields of a constructor are in. By default Java does not provide the parameter names for constructor arguments. They're purely positional. We do however include that information as debug symbols and de-serialisers are smart enough to read those. But they can be optimized out (cucumber/messages-cli#50) for smaller runtime images.
By adding an annotation with the property name, de-serialisers will be able to match constructor fields to values.
🏷️ What kind of change is this?
📋 Checklist: