Daccess 609 only output ld acknowledge div if the data exists#2356
Daccess 609 only output ld acknowledge div if the data exists#2356JeremyDuncan wants to merge 19 commits intodevfrom
Conversation
…SS-609_Only-output-ld-acknowledge-div-if-the-data-exists
mhk33
left a comment
There was a problem hiding this comment.
When I look at this one in prod or container-int, there is an image attribution, but I'm not seeing it locally in this branch:
http://localhost:9292/browse/info?authq=Shakespeare%2C+William%2C+1564-1616.&browse_type=Author&headingtype=Personal%20Name
Attribution on prod: https://catalog.library.cornell.edu/browse/info?authq=Shakespeare%2C+William%2C+1564-1616.&bib=16444015&browse_type=Author&headingtype=Personal+Name
Do you know why this would be?
Also for this one: http://localhost:9292/browse/info?authq=History&browse_type=Subject&headingtype=Topical%20Term
I see an empty wiki-acknowledge span - should we also suppress that span if there is no data for it?
|
Hmm I may have gotten a big aggressive with the javascript since most of the rendering logic is a script and not view code. I'm looking into it. Thank you for the examples! I may had to take a different approach with this. |
…SS-609_Only-output-ld-acknowledge-div-if-the-data-exists
Jira Ticket: https://culibrary.atlassian.net/browse/DACCESS-609?atlOrigin=eyJpIjoiZmZjNTk2ZGRjNDJiNGQzZmJjMTZkOWJiNTA0NzBhMjciLCJwIjoiaiJ9
Changes
http://localhost:9292/browse/info?authq=Art&browse_type=Subject&headingtype=Topical%20Term
http://localhost:9292/browse/info?authq=History&browse_type=Subject&headingtype=Topical%20Term