Skip to content

Daccess 609 only output ld acknowledge div if the data exists#2356

Open
JeremyDuncan wants to merge 19 commits intodevfrom
DACCESS-609_Only-output-ld-acknowledge-div-if-the-data-exists
Open

Daccess 609 only output ld acknowledge div if the data exists#2356
JeremyDuncan wants to merge 19 commits intodevfrom
DACCESS-609_Only-output-ld-acknowledge-div-if-the-data-exists

Conversation

@JeremyDuncan JeremyDuncan requested review from mhk33 and sk274 October 10, 2025 19:24
Copy link
Copy Markdown
Contributor

@mhk33 mhk33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at this one in prod or container-int, there is an image attribution, but I'm not seeing it locally in this branch:
http://localhost:9292/browse/info?authq=Shakespeare%2C+William%2C+1564-1616.&browse_type=Author&headingtype=Personal%20Name

Attribution on prod: https://catalog.library.cornell.edu/browse/info?authq=Shakespeare%2C+William%2C+1564-1616.&bib=16444015&browse_type=Author&headingtype=Personal+Name

Do you know why this would be?

Also for this one: http://localhost:9292/browse/info?authq=History&browse_type=Subject&headingtype=Topical%20Term

I see an empty wiki-acknowledge span - should we also suppress that span if there is no data for it?

@JeremyDuncan
Copy link
Copy Markdown
Contributor Author

http://localhost:9292/browse/info?authq=Shakespeare%2C+William%2C+1564-1616.&browse_type=Author&headingtype=Personal%20Name

Hmm I may have gotten a big aggressive with the javascript since most of the rendering logic is a script and not view code. I'm looking into it. Thank you for the examples! I may had to take a different approach with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants