Skip to content

Sync link_back_to_catalog to bl7 version#2437

Draft
chrisrlc wants to merge 2 commits intodevfrom
link-back-to-catalog
Draft

Sync link_back_to_catalog to bl7 version#2437
chrisrlc wants to merge 2 commits intodevfrom
link-back-to-catalog

Conversation

@chrisrlc
Copy link
Copy Markdown
Contributor

@chrisrlc chrisrlc commented Mar 11, 2026

WIP:

  • Need test for link back from item selected from bento search results
    • Should really think through what controllers needs to share actions from CatalogController, which ones need search history saved and current_search_sessions, Blacklight::SearchContext, Blacklight::SearchState, and etc, esp. related to SearchController vs DatabasesController vs Bookmarks, BookBags, DigitalCollections, etc
  • Need test to verify no link back rendered when going from /digitalcollections to /catalog/ID (test exists from /databases --> /catalog/ID)

Follow-up to #2435

  • Updates #link_back_to_catalog overridden from a long ago version of blacklight to use updated logic from bl 7
  • Allows us to remove overridden #blacklisted_search_session_params that I'd introduced as part of DACCESS-820, 821, 822 - Address bl 8 deprecations #2435
  • Explicitly render link back only when current_search_session (matches blacklight) or for bookmarks/book_bags#show, which links back to related controller's index
  • Updates analytics tracking label for link from 'back ToSearch' to 'back ToSearch' after verifying with Melissa and Sarah that this is what's actually stored in Matomo

@chrisrlc chrisrlc force-pushed the DACCESS-693-deprecations-cc branch from d66c910 to 3d75ac7 Compare March 11, 2026 15:11
@chrisrlc chrisrlc force-pushed the link-back-to-catalog branch from de35e57 to 3f79908 Compare March 11, 2026 15:38
@chrisrlc chrisrlc changed the base branch from DACCESS-693-deprecations-cc to dev March 11, 2026 15:39
@chrisrlc chrisrlc force-pushed the link-back-to-catalog branch 3 times, most recently from c17d32c to 6158399 Compare March 11, 2026 18:08
@chrisrlc chrisrlc force-pushed the link-back-to-catalog branch from 6158399 to 8d75aa4 Compare March 11, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant