Audio workspace: change cursor and hover element in draw region mode - #11136
Open
lexiv0re wants to merge 6 commits into
Open
Audio workspace: change cursor and hover element in draw region mode#11136lexiv0re wants to merge 6 commits into
lexiv0re wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
When in
Drawmode nothing shows it besides the left control bar button state.This PR changes the
Drawmode cursor totext. It's consistent with some other tools interval creation.Also, changes the hover element vertical guide color to red. It's consistent with red crosshair displayed in 2D in
Drawmode.With the hover vertical guide highlighted in red it became more apparent that the standard WaveSurfer region creation handling has some issues:
So these changes additionally fix all the aforementioned issues by taking over the region creation logic.
How has this been tested?
Tested manually.
Adjusted e2e tests.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.