feat(shell): host clipboard via OSC 52 on grain sh - #24
Merged
Conversation
Intercept OSC 52 (and tmux DCS-wrapped) sequences on the grain sh client path and write the payload to the local clipboard so guest TUIs like Grok Build can copy on highlight. Works for local agent PTY and remote daemon-proxied shells. Disable with GRAIN_OSC52_CLIPBOARD=0.
|
Coverage (lines): commit Coverage report by file (79% overall — click to expand)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grok Build (and similar TUIs) copy on highlight via OSC 52 when they are not on the local OS clipboard. That works on a laptop terminal, but
grain shonly forwarded PTY bytes — terminals without native OSC 52 (e.g. Apple Terminal) never applied the sequence, and even capable terminals could miss host-side copy depending on the path.This change intercepts OSC 52 on the host
grain shclient (agent WebSocket shell, including remoteGRAIN_APIproxy) and writes the decoded payload to the local clipboard:pbcopywl-copy, elsexclip, elsexselAlso handles tmux DCS-wrapped OSC 52 (
ESC P tmux; …). Sequences still pass through by default so iTerm2/Ghostty/Kitty keep native handling.GRAIN_OSC52_CLIPBOARD=0GRAIN_OSC52_PASSTHROUGH=0Test plan
go test ./internal/osc52/go test ./internal/agent/grain shinto a sandbox, run Grok Build, highlight text → host clipboard has itGRAIN_API=… grain sh)GRAIN_OSC52_CLIPBOARD=0 grain sh→ no host copy