Enhancement Add PROTOSpawner - #819
Draft
ygoumaz wants to merge 8 commits into
Draft
Conversation
IDavGal
reviewed
Jul 10, 2023
Co-authored-by: Ignacio Davila <99193391+IDavGal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #818.
spawn_urdf_robotservice and its callback.URDFSpawnernode.webots_ros2_importermodule.spawn_node_from_stringcallback tospawn_proto_robotcallback (drafted in this PR):request.robot.robot_string.request.robot.proto_pathsand must be added to IMPORTABLE EXTERNPROTO (Add new elements to IMPORTABLE list from Supervisor API webots#6316).PROTOSpawnernode (drafted in this PR).webots_ros2_universal_robotto spawn UR5e from PROTO.Ros2Supervisortutorial to the new service architecture.PROTOSpawneror directly via the service.