Skip to content

Added channel handling from Paeetech - #6

Open
dsjstc wants to merge 2 commits into
cybergibbons:masterfrom
dsjstc:master
Open

Added channel handling from Paeetech#6
dsjstc wants to merge 2 commits into
cybergibbons:masterfrom
dsjstc:master

Conversation

@dsjstc

@dsjstc dsjstc commented Feb 11, 2019

Copy link
Copy Markdown

No description provided.

@kschwank kschwank left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the name of the include would be changed, the library cannot be used as a drop-in replacement for the OneWire library to be used for example with the DallasTemperature library.

maxus-git added a commit to maxus-git/DS2482_OneWire that referenced this pull request Dec 14, 2023
- Changes from the Pull Request cybergibbons#6 and cybergibbons#9
@gkostov

gkostov commented Nov 6, 2024

Copy link
Copy Markdown

If the name of the include would be changed, the library cannot be used as a drop-in replacement for the OneWire library to be used for example with the DallasTemperature library.

Yes, but this is more a problem of DallasTemperature which insists on the name of the include. Because of this I'm currently creating a soft link named OneWire to either the PJRC library or this one depending on whether I need software or hardware handling of the protocol. The name chosen here (DOneWire) is arguably a good pick but it does the job of being different and I'd love it if DallasTemperature gets modified to allow the user to include their preferred library.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants