Adding or updating tests to improve codecov coverage.#7292
Open
samuel-denton wants to merge 10 commits into
Open
Adding or updating tests to improve codecov coverage.#7292samuel-denton wants to merge 10 commits into
samuel-denton wants to merge 10 commits into
Conversation
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
…ecov) Added test for CommandFailedError in exceptions.py Update test_exceptions.py Linter wants 2 blank lines at the end of the file. Update test_exceptions.py Linter now wants the blank lines removed... Test added for FileRemovalError(CylcError): added test for CylcVersionError Test added for TaskOutputs.is_message_complete() Update test_exceptions.py Shortened a line to make the linter happy Added 2 new tests to cover TaskOutputs.format_completion_status() Included a test for color wrap even though codecov says its covered as I think the if statements are reached but each branch is not explored so I've added that. Added test for TaskOutputs._is_compvar_complete() added test for CylcTimeParser.parse_timepoint() for when point is None and for CylcTimeParser.parse_recurrence() when expression is unparsable. Added test to cover all 10 branches of CylcTimeParser._get_interval_from_expression() Added test for CylcTimeParse.parse_recurrence() for the case there start and end points are provided. Added test for CylcTimeParser._get_min_from_expression() for the case where a valid offset if provided for the point, and context is None. Added test for CylcTimeParser._get_point_from_expression() for the case where a point is provided, but it resolves to a non real point (hour 25) Added test for CylcTimeParser.parse_timepoint() for the case where the point given is None. Added 3 tests for branches of TaskProxy.get_point_as_seconds() Added test for TaskProxy.is_ready_to_run() for 7 different cases.
samuel-denton
force-pushed
the
8.6.x_7277_codecov
branch
from
dd43142 to
e74fe10
Compare
samuel-denton
commented
May 19, 2026
Member
|
From the latest coverage run:
Nice. There is some random jitter which has caused coverage in |
Moved imports
oliver-sanders
approved these changes
May 20, 2026
MetRonnie
reviewed
Jun 10, 2026
|
|
||
|
|
||
| def test_get_interval_from_expression(parsers): | ||
| """It should infer interval from truncated context point.""" |
Member
There was a problem hiding this comment.
Unfortunately the function being tested is the cause of a bug: #2382 (comment)
We can keep the tests but it would be worth referencing the issue in the docstring
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
samuel-denton
commented
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7277
Adding some new tests or updating tests to improve code coverage.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.