Skip to content

remove Cylc 7 compatibility mode#7325

Open
oliver-sanders wants to merge 5 commits into
cylc:masterfrom
oliver-sanders:compat
Open

remove Cylc 7 compatibility mode#7325
oliver-sanders wants to merge 5 commits into
cylc:masterfrom
oliver-sanders:compat

Conversation

@oliver-sanders

@oliver-sanders oliver-sanders commented Jun 3, 2026

Copy link
Copy Markdown
Member

A set of changes to remove Cylc 7 compatibility mode, issues:

Sibling PRs:

Summary:

  • remove cylc 7 compatibility mode:
    • Closes drop compatibility mode #6849
    • Remove Cylc 7 compatibility mode.
    • Remove support for validating, (re)installing or (re)starting suite.rc workflows.
    • Keep support for CLI commands against workflows running under older versions of Cylc 8.
    • Remove legacy functional tests.
    • Add integration tests (to ensure suite.rc workflows cannot be started).
  • setup: unpin Jinja2:
  • suite.rc: schedule removal of remaining support
    • Cylc 8 is still suite.rc "aware" for now, it's needed for GUI/Tui/CLI.
    • Following the logic laid out in review BACK COMPAT code #7274, this support would be removed in Cylc 8.10.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at remove documentation for Cylc 7 compatibility mode cylc-doc#939.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.7.0 milestone Jun 3, 2026
@oliver-sanders oliver-sanders self-assigned this Jun 3, 2026
@oliver-sanders oliver-sanders changed the title Compat remove Cylc 7 compatibility mode Jun 3, 2026
oliver-sanders added a commit to oliver-sanders/cylc-doc that referenced this pull request Jun 3, 2026
* Closes cylc#6849
* Remove Cylc 7 compatibility mode.
* Remove support for validating, (re)installing or (re)starting
  `suite.rc` workflows.
* Keep support for CLI commands against workflows running under older
  versions of Cylc 8.
* Remove legacy functional tests.
* Add integration tests (to ensure `suite.rc` workflows cannot be
  started).
* Remove redundant Parsec `silent` option.
* Closes cylc#6850
* Remove the upper pin on Jinja2 allowing the use of newer versions.
@oliver-sanders oliver-sanders marked this pull request as ready for review June 11, 2026 12:28
Comment on lines +140 to +144
asyncio.run(run(options, workflow_id))


async def run(
parser: COP, options: 'Values', workflow_id: str
options: 'Values', workflow_id: str

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off-topic change: A couple of scripts were passing through the unused parser argument which was creating hassle for tests.

* The flags module contains global variables, generally considered an
  anti-pattern.
* We're down to the last flag, add a note to discourage the addition of
  any new ones!
* Support for running workflows defined by `suite.rc` files was removed
  in Cylc 8.7 (cylc#7325)
* However, Cylc 8 remains `suite.rc` "aware" in order to allow the GUI,
  Tui and CLI to list and operate on workflows running under older
  versions.
* A version has been set for the removal of this support in line with
  cylc#7274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jinja2: bump version drop compatibility mode

1 participant