Add interactive config wizard and fix docs#7
Merged
Conversation
configure.sh walks users through generating arbiter.toml interactively instead of requiring manual toml editing. install.sh now offers to run it after binary install. fixes deploy/arbiter.toml trust_level casing that caused startup crash, wrong auth header in deploy docs, and missing fields in example curl commands.
Owner
Author
|
E2E test complete — full Steps run:
Note: this test machine has ports 8080/3000 already bound by other services, so the config was rewritten to 18080/13000. The generated defaults (8080/3000) and the All test-plan items now check out. |
- Cargo.lock: rustls-webpki 0.103.10 -> 0.103.12 to resolve RUSTSEC-2026-0098 and RUSTSEC-2026-0099 (name-constraint bypasses for URI and wildcard names in TLS cert validation). - storage_registry.rs: replace the outer match + nested if pattern with let-else + combined if to satisfy clippy 1.95's collapsible_match lint without putting .await in a match guard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sort_by Two reverse-sort-by-numeric-key sites flagged by clippy 1.95's unnecessary_sort_by lint. The suggestion pattern (sort_by_key(|b| std::cmp::Reverse(b.1))) is slightly faster and reads more clearly than the manual comparator. - crates/arbiter-policy/src/eval.rs:145 - crates/arbiter-policy/src/model.rs:392 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Rustfmt prefers the combined if-condition on a single line since it fits within the line budget. Cosmetic-only; behavior unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure.sh, an interactive config wizard that walks users through generatingarbiter.tomlinstead of requiring manual TOML editinginstall.shnow offers to run the wizard after binary installdeploy/arbiter.tomltrust_levelcasing (uppercaseVerified/Trusted→ lowercase) that caused startup crashcurlcommands in quickstartPorted from the upstream working tree.
Test plan
mainconfigure.sh --non-interactive --output test.tomlruns without error and produces a filepython3 -c "import tomllib; tomllib.load(...)")configure.sh --helpprints usagetrust_levelvalues indeploy/arbiter.tomlnow use lowercase (verified,trusted)🤖 Generated with Claude Code