Skip to content

fix: do not invent Unknown error on successful executions - #1070

Open
Pitchfork-and-Torch wants to merge 1 commit into
czlonkowski:mainfrom
Pitchfork-and-Torch:fix/error-mode-no-invented-error
Open

fix: do not invent Unknown error on successful executions#1070
Pitchfork-and-Torch wants to merge 1 commit into
czlonkowski:mainfrom
Pitchfork-and-Torch:fix/error-mode-no-invented-error

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown
Contributor

Bug

n8n_executions with mode=error on an execution whose top-level status is success still built an error analysis. extractPrimaryError fell back to the last node and the string Unknown error, and buildExecutionPath marked that node as failed. Maintainers hit this live on n8n 2.37.7 (issue #1065).

Fix

If there is no resultData.error and no node-level error, error mode now returns success: true, a None primary error that says there is nothing to diagnose, and an execution path that keeps real node statuses.

Tests

Unit test covers a successful three-node execution: no invented error, no error status on the path, Nothing to diagnose suggestion.

Closes #1065

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/services/error-execution-processor.ts 90.90% 4 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

n8n_executions mode=error reports "Unknown error" on a successful execution

1 participant