Name the reconnect gesture the same everywhere - #29
Merged
Conversation
The dashboard card and the settings switch drive the same preference but
were both labelled "Reconnect for 100%", while the settings section above
the switch was labelled "Reconnect gesture" - so the feature had two names
and the section duplicated nothing useful.
Both controls are now "Reconnect gesture". The section header becomes
"Quick full charge", matching the vocabulary the ongoing notification
already uses ("Quick full charge is on"), which also avoids a section and
the switch inside it sharing a title.
Dropped formatted="false" from both strings; neither contains a literal %
any more. Re-rendered the affected store screenshot.
Restores an abandoned local branch (1aeda8b) that renamed only the
dashboard card, extended to keep the naming consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The quick-full-charge feature had two different names in the app. The dashboard card and the switch in Settings → Charging control the same thing but were both called "Reconnect for 100%", while the section heading directly above that switch called it "Reconnect gesture".
Both controls are now called "Reconnect gesture", and the section heading becomes "Quick full charge" — the same wording the ongoing notification already uses. So the settings screen now reads Charging › Quick full charge › Reconnect gesture, instead of a section and the switch inside it sharing one title.
No behaviour changes — text only.
Technical Context
Renaming only the dashboard card (the original intent) would have left it disagreeing with the settings switch for the same preference, so both were renamed together. That in turn collided with the section header, which the Robolectric UI tests caught immediately — three
ChargingSettingsScreenTestcases failed with "Expected exactly 1 node but found 2" because the section title and the switch title became identical strings. Retitling the section resolves it, rather than loosening the test selectors: two identically-labelled elements one above the other was a real UI problem, not test brittleness.formatted="false"was dropped from both renamed strings — it was only there for the literal%in "100%", which is gone.Every reference goes through
R.string.*, so no Kotlin changed. The committed store screenshot showing this screen was re-rendered; the dashboard shot was unaffected.Restores work from an abandoned local branch (
1aeda8b, 2026-07-23) that renamed only the dashboard card, extended for consistency.Verification
739 unit tests, lint (both flavors, beta + release) and both flavor debug assembles pass.