Use one name for the reconnect gesture - #30
Merged
Conversation
The gesture was called "Reconnect gesture" in the notification channel,
the dashboard card, the settings switch and the settings hub subtitle,
but "Quick full charge" in the gesture notification's title and in the
settings section header above the switch.
"Reconnect gesture" wins. The competing name overlapped the temporary
full-charge session, which already owns that vocabulary ("Temporary full
charge", "Charging to 100% once", the "100% once" tile) - so the trigger
and the thing it triggers sounded like one feature.
- gesture_notification_title: "Quick full charge is on" -> "Reconnect
gesture is on"
- settings_reconnect_category: "Quick full charge" -> "Trigger", so the
section does not repeat the switch inside it
- a settings preview fixture carrying the retired name
The temporary-full-charge strings are deliberately untouched. Re-rendered
the affected store screenshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The unplug/replug feature answered to two names. It was "Reconnect gesture" on the dashboard card, on the settings switch, in the settings list, and on its notification channel — but "Quick full charge" in the title of the notification it posts, and in the settings heading directly above its own switch.
It's now "Reconnect gesture" everywhere:
The temporary full charge — the thing the gesture actually starts — keeps its own wording ("Temporary full charge", "Charging to 100% once", the "100% once" tile). That was already consistent and is deliberately untouched.
No behaviour changes — text only.
Technical Context
"Reconnect gesture" was chosen over "Quick full charge" because the latter collided with the temporary-full-charge session, which already owns that vocabulary across its channel, notification, dashboard card, widget and tile. Keeping "full charge / 100% once" exclusive to the session means the trigger and the thing it triggers stay distinguishable; naming both "quick full charge" would have made one feature read as two names for the same thing, and vice versa.
The section header could not simply become "Reconnect gesture" too — a section and the switch inside it sharing a title is what broke three
ChargingSettingsScreenTestcases in the previous PR ("Expected exactly 1 node but found 2"). "Trigger" restores the value the header had before the Charging screen gained a master switch.Also updated one hardcoded occurrence in a settings preview fixture — dummy data, not runtime text, but a retired name there would mislead the next person editing that file. A repo-wide grep for the old name now returns nothing outside binary assets.
Left alone deliberately: the onboarding page still pitches this as "Optional cable shortcut". That is descriptive copy rather than a competing label, and rewriting an onboarding pitch is a different kind of decision — happy to follow up if you want it named there too.
Verification
739 unit tests, lint (both flavors, beta + release) and both flavor debug assembles pass. The committed store screenshot showing the settings section was re-rendered; the other five were unaffected.