Dashboard: Show the adapter's standing capability note on supported devices - #58
Merged
Conversation
…evices
The adapter_detail_*_ready strings were dead copy: AdapterSupport.detail
only ever reached the UI through the Unsupported/NeedsSetup observation,
so a healthy device had no per-adapter hint surface at all. ChargingState
now carries the detail as adapterDetail - populated only while control is
enabled, which by every probe's when-cascade construction is exactly when
detail holds the ready string, so a gate-failure reason can never print
twice - and the dashboard's provenance block renders it between the
readback line and the device line. The six strings are reworded from
probe-log phrasing ("...detected; ...") into standing facts (write
latency on Pixel, immediate application on Samsung/Xiaomi, the Shizuku
requirement on Oplus/LineageOS, replug semantics on GrapheneOS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Supported devices now show a short standing note under the policy card's provenance section describing how this device applies charging changes — "changes take about 15 seconds to reach the hardware" on Pixel, "changes apply immediately" on Samsung/Xiaomi, the Shizuku requirement on ColorOS/LineageOS, and the reconnect-to-apply behavior on GrapheneOS. Previously this copy existed but was unreachable: it only ever rendered on unsupported devices.
Technical Context
adapter_detail_*_readystrings were dead copy —AdapterSupport.detailonly reached the UI through the Unsupported/NeedsSetup observation. The newChargingState.adapterDetailfield is populated only while control is enabled, which every probe's when-cascade construction makes exactly the case wheredetailholds the ready string — verified per adapter, so a gate-failure reason can never render twice.