General: Refresh the store screenshots and swap two of the six - #88
Merged
Conversation
A charger condition naming more than one plug type read "While charging via Wireless,Dock". The separator resource was authored as ", " but Android strips leading and trailing whitespace from an unquoted string resource, so the value reaching joinLabels() was a bare comma. Quoting the resource preserves the space.
The committed PNGs predated ~85 UI commits: the charging card, the enforcement tier line, the adapter capability note and the setup guide had all moved on. Re-rendered all six from the current fixtures. Two shots also changed subject. The Samsung multi-mode shot had become indistinguishable from the dashboard shot — same hero, chart and full-charge card, differing only in the device line, with the multi-mode chips it existed to show sitting below the fold. The theme-settings shot was three rows on an otherwise empty screen. They are replaced by the charge-conditions rule list and the battery hub, neither of which appeared anywhere before. The hub shot reuses HubFixtures' tile-grid content rather than a second copy, so the store shot cannot drift from the engineering regression shot that renders the same composable.
d4rken
marked this pull request as ready for review
August 19, 2026 13:10
github-actions
Bot
added
Build/Deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The screenshots in the README and the Play Store listing were rendered before roughly 85 UI commits landed, so they no longer matched the app. All six are re-rendered from the current UI.
Two of them also show something different now:
A charge condition covering more than one charger type also read "While charging via Wireless,Dock" with the space missing. It now reads "Wireless, Dock".
Technical Context
", "instrings.xml, but Android strips leading/trailing whitespace from an unquoted string resource, sojoinLabels()received a bare comma. Quoting the resource is the fix; it is a real in-app text bug, not a screenshot artifact, and it has its own commit.HubFixtures' existing tile-grid content instead of a second fixture, so it renders the same composable as the engineering regression shot and cannot drift from it.fastlane/copy_screenshots.shand the raw links in the README; both are in this PR. CI compiles the screenshot sources but never renders them, so regeneration stays a manual step.ScreenshotContent.kt, where the dropped Samsung fixture also removes theSettingProbe/ThemeStateimports.