IOS-1269 feat: add AddComponentModifier Macro#54
Merged
ElonPark merged 7 commits intoSep 16, 2025
Conversation
89f98b7 to
1169037
Compare
1169037 to
938a49f
Compare
Base automatically changed from
task/ray/NO-TICKET-resolve-test-crash
to
main
September 15, 2025 05:36
938a49f to
d34bde9
Compare
# Conflicts: # .github/workflows/ci-sampleapp.yml # .github/workflows/ci.yml
cdebb6d to
17e33e9
Compare
17e33e9 to
372d8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background (Required)
Changes (Required)
Swift Macros Infrastructure Setup
5.5to5.9inPackage.swiftswift-syntaxdependency (509.0.0..<602.0.0) for macro compilation supportKarrotListKitMacrostarget with compiler plugin supportKarrotListKitMacrosTeststarget for macro testing@AddComponentModifier Macro Implementation
@AddComponentModifierpeer-attached macro inAddComponentModifier.swiftAddComponentModifierMacro.swiftwith logic to:AccessLevelModifier.swiftfor handling access levels (public, internal, private)KarrotListKitMacroError.swiftfor error handlingKarrotListKitPlugin.swiftfor compiler plugin registrationSample App Updates
VerticalLayoutItemComponent.swiftwith macro usage examples:CI/CD Pipeline Modernization
check-macro-compatibilityjob for Swift macro compatibility verificationTest Methods (Required)
Unit Tests Added
AddComponentModifierMacroTests.swift(167 lines) covering:CI/CD Testing Strategy
Review Notes
Key Review Points
@AddComponentModifiermacro eliminates boilerplate code by automatically generating setter methods for closure propertiesDesign Decisions
onTapButtonHandler→onTapButton()method)Future Considerations
Technical Dependencies