fix(segmented-control): type SegmentedControlItem with its declared props interface#1775
fix(segmented-control): type SegmentedControlItem with its declared props interface#1775te6-in wants to merge 1 commit into
Conversation
…rops interface The forwardRef generic used the narrow UseSegmentedControlItemProps (value/invalid/disabled only) instead of the declared SegmentedControlItemProps, so children/className/asChild were rejected at the type level. Runtime behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changes세그먼트 컨트롤 아이템
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rops interface The forwardRef generic used the narrow UseSegmentedControlItemProps instead of the SegmentedControlItemProps interface declared right above, rejecting children/className/asChild at the type level while the runtime always spread them. No runtime change. Same fix as #1775; kept as a standalone commit so a rebase onto dev drops it automatically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary by CodeRabbit