Skip to content

fix(segmented-control): type SegmentedControlItem with its declared props interface #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
te6-in wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(segmented-control): type SegmentedControlItem with its declared props interface #1775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/react-headless/segmented-control/src/SegmentedControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,20 @@ export interface SegmentedControlItemProps
PrimitiveProps,
Omit<React.InputHTMLAttributes<HTMLLabelElement>, "value"> {}

export const SegmentedControlItem = React.forwardRef<
HTMLLabelElement,
UseSegmentedControlItemProps
>((props, ref) => {
const { value, invalid, disabled, ...otherProps } = props;
const { getItemProps } = useSegmentedControlContext();
const itemProps = getItemProps({ value, disabled, invalid });
const mergedProps = mergeProps(itemProps.rootProps, otherProps);
export const SegmentedControlItem = React.forwardRef<HTMLLabelElement, SegmentedControlItemProps>(
(props, ref) => {
const { value, invalid, disabled, ...otherProps } = props;
const { getItemProps } = useSegmentedControlContext();
const itemProps = getItemProps({ value, disabled, invalid });
const mergedProps = mergeProps(itemProps.rootProps, otherProps);

return (
<SegmentedControlItemProvider value={itemProps}>
<Primitive.label ref={ref} {...mergedProps} />
</SegmentedControlItemProvider>
);
});
return (
<SegmentedControlItemProvider value={itemProps}>
<Primitive.label ref={ref} {...mergedProps} />
</SegmentedControlItemProvider>
);
},
);
SegmentedControlItem.displayName = "SegmentedControlItem";

export interface SegmentedControlItemHiddenInputProps
Expand Down