Skip to content

perf(stackflow): backport WAAPI css changes to 1.1 (css-only)#1552

Merged
junghyeonsu merged 5 commits into
1.1from
backport/waapi-css-only-to-1.1
May 7, 2026
Merged

perf(stackflow): backport WAAPI css changes to 1.1 (css-only)#1552
junghyeonsu merged 5 commits into
1.1from
backport/waapi-css-only-to-1.1

Conversation

@junghyeonsu

Copy link
Copy Markdown
Contributor

Summary

dev에 머지된 PR #1444 (WAAPI AppScreen transitions)의 css 변경 부분만 1.1 라인에 백포팅합니다.

Why css-only

@seed-design/stackflow 레지스트리 슬롯 1.1.17 ~ 1.1.21이 이미 dev 라인 배포로 점유되어 있어, 1.1 라인에서 stackflow를 patch publish하려면 1.1.22 이상으로 jump해야 합니다. 그래서 분업 방식을 채택했습니다:

  • dev (별도 PR, 사용자 직접 처리): stackflow 1.1.22 patch publish. 코드 변경 없이 peerDependencies['@seed-design/css']만 정확한 호환 범위로 정정 (>=1.1.25 <1.2.0 || >=1.2.11).
  • 이 PR (1.1): css 패키지만 1.1.24 → 1.1.25 백포팅. qvism-preset의 stackflow 관련 4개 파일 + 재생성된 css 산출물.

이후 1.1 라인 사용자가 bun update로 stackflow를 자동 1.1.22로 받게 되고, 정확한 peerDeps에 따라 css도 1.1.25로 함께 올라가야 정상 동작합니다.

What changed

  • .changeset/config.json: linked 그룹을 dev 식으로 축소 ([figma, mcp], [codemod, migration-index]만). css 단독 patch bump가 가능하도록.
  • packages/qvism-preset/src/stackflow/: animation.ts/pseudo.ts 삭제, app-bar.ts/app-screen.ts 수정 (transition selector 제거 + AppBar background slot 추가). PR perf(stackflow): backport WAAPI AppScreen transitions to 1.1 #1548 backport 브랜치에서 동일 내용을 가져옴.
  • packages/css/recipes/, packages/css/all.{css,min.css}: bun qvism:generate 결과 재생성. PR #1548의 css 산출물과 정확히 일치.
  • 새 changeset (@seed-design/css: patch): 호환 stackflow 버전 명시.

호환성

@seed-design/css@1.1.25는 다음 stackflow 버전과 호환됩니다:

  • @seed-design/stackflow@>=1.1.22 <1.2.0 (1.1 라인, dev 작업 머지 후 publish)
  • @seed-design/stackflow@>=1.2.11 (dev 라인)

stackflow 1.1.16 ~ 1.1.21과 함께 사용하면 화면 전환 애니메이션 / AppBar 배경이 깨질 수 있으니, 두 패키지를 함께 업그레이드해야 합니다.

머지 순서

  1. First: dev에서 stackflow 1.1.22 publish 완료 (별도 PR)
  2. Then: 이 PR 머지 → css 1.1.25 publish

Test plan

  • bun packages:build 통과
  • bun test:all — 376 tests pass (회귀 없음)
  • bunx changeset status@seed-design/css: patch (1.1.24 → 1.1.25). figma/mcp는 css의 dependent로 자동 동반 patch.
  • backport 브랜치의 css 산출물과 diff 빈 출력 확인 (정확히 일치)
  • dev stackflow 1.1.22 publish 완료 후, examples/stackflow-spa 동등 환경에서 push/pop/swipe back 수동 검증

Cherry-picked from

- Remove transition CSS animation selectors that conflict with WAAPI
- Add appBar background slot in place of :before pseudo-element
- Delete unused animation.ts and pseudo.ts
- Pairs with @seed-design/stackflow >=1.1.22 (1.1 line) or >=1.2.11 (dev line)
@changeset-bot

changeset-bot Bot commented May 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 180d406

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49694053-ef75-4a06-af37-018ec0c59b88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport/waapi-css-only-to-1.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The Grid component does not exist in the 1.1 react package (was added
only in dev), so docs build has been failing since #1423. Use a plain
div with inline grid styles to unblock the 1.1 docs build.

Cherry-picked from #1548.
@junghyeonsu
junghyeonsu merged commit d71e6db into 1.1 May 7, 2026
3 of 4 checks passed
@junghyeonsu
junghyeonsu deleted the backport/waapi-css-only-to-1.1 branch May 7, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant