fix(registry): scope docs registry output under react framework path (1.1)#1657
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of #1591 (react portion) for DES-1932. The latest @seed-design/cli resolves snippets from `{baseUrl}/__registry__/{framework}/...`, but the 1.1 maintenance deploy (1-1.seed-design.pages.dev) still served the legacy flat layout `{baseUrl}/__registry__/{ui,lib,breeze}/...`, breaking `add-all --baseUrl`. - Re-path the generated registry under `react/` and add a top-level `__registry__/index.json` advertising the react framework. - Update generate-registry.ts to emit the framework-scoped layout. - Point the manual-installation consumers at the new react/ paths. lynx is intentionally excluded: this branch has no lynx components, and advertising it would make the CLI request a non-existent lynx/ registry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The docs deploy pipeline pinned bun 1.3.6, where `bun install --frozen-lockfile` hangs (CI runner lost communication after ~2.5h with no install output). dev uses bun 1.3.13, which installs this monorepo cleanly. Bump the docs/qa/storybook deploy workflows to 1.3.13 so the docs build can run and publish the framework-scoped registry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mple 1.1's MenuSheetItem renders children (a PrefixIcon plus label text), not `label`/`prefixIcon` props. The example used the newer prop-based API and broke the docs typecheck. Match the sibling examples (e.g. with-prefix-icon). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bdd4571 to
a839faa
Compare
1 participant
배경
@seed-design/cli@latest는 스니펫을{baseUrl}/__registry__/{framework}/...에서 읽도록 바뀌었는데(dev: #1591 + Lynx 작업),1.1유지보수 배포(1-1.seed-design.pages.dev)는 여전히 옛 flat 구조(__registry__/{ui,lib,breeze}/...)를 서빙해add-all ... --baseUrl https://1-1.seed-design.pages.dev가 깨졌습니다 (DES-1932).이 PR은 #1591의 react 부분 백포트에 더해, 그동안 막혀 있던 1.1 docs 빌드/배포를 안정화하는 수정까지 함께 담았습니다. (빌드가 통과해야 새 registry가 실제로 배포되므로 한 PR에 묶었습니다.)
변경 사항
1) Registry를 framework 스코프로 재배치 (핵심)
public/__registry__/{ui,lib,breeze}/...→public/__registry__/react/...로 이동 (순수 re-path, 컴포넌트 JSON 내용 무변경).public/__registry__/index.json=[{ "id": "react" }]추가.docs/scripts/generate-registry.ts가 framework 스코프 레이아웃을 생성하도록 수정 (향후bun generate:registry재현).manual-installation.tsx,breeze-manual-installation.tsx) import 경로를react/로.lynx/를 404 조회.3) docs-deploy bun
1.3.6→1.3.13(dev 정렬)4) menu-sheet 예제 타입 수정
docs/examples/react/menu-sheet/open-change-reason.tsx가 1.1에 없는label/prefixIconprop을 사용해 docs 타입체크 실패. 1.1의 children 기반 API(형제 예제with-prefix-icon와 동일:<MenuSheetItem><PrefixIcon .../>텍스트</MenuSheetItem>)로 수정.의도적으로 제외
packages/cli) — main/dev에서 배포되므로 유지보수 브랜치 백포트 불필요.docs/registry/소스 디렉토리 재구성 — 외부 CLI는 배포 JSON에 임베드된 스니펫을 읽고docs명령의 raw URL은dev로 고정이라 무관. 최소 diff를 위해 소스는 flat 유지.검증
react/JSON 개수 = 이전 flat 개수(44=44, 무손실), 레이아웃이 dev의react/와 동일(1.1엔 없는block만 제외).fetchAvailableRegistries→__registry__/react/index.json, item →__registry__/react/{id}/{item}.json)과 정확히 매핑.배포 시점 주의
PR CI의 deploy는 PR 브랜치 프리뷰로 나갑니다.
1-1.seed-design.pages.dev(=1.1브랜치 별칭)에는 이 PR을1.1에 머지한 뒤1.1브랜치 deploy가 돌 때 반영됩니다. 이제 그 브랜치 빌드도 동일 수정으로 통과합니다.🤖 Generated with Claude Code