Merged
Conversation
Replace vm.readFile artifact parsing with forge inspect FFI call to fetch only methodIdentifiers, eliminating full artifact JSON dumps in test and script traces.
Add 81 new tests across 3 test files covering diamond cut operations (add/replace/remove), all error conditions, ownership transfer and handover ceremonies, role management, MultiInit error paths, ETH handling, and ERC-165 compliance edge cases.
Remove duplicate addFunctions, replaceFunctions, removeFunctions, diamondCut, and initializeDiamondCut memory variants. Rename calldata variants to be the canonical functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.