Update Vanara.WinUI.Extensions build environment#594
Draft
tajbender wants to merge 9 commits intodahall:masterfrom
Draft
Update Vanara.WinUI.Extensions build environment#594tajbender wants to merge 9 commits intodahall:masterfrom
Vanara.WinUI.Extensions build environment#594tajbender wants to merge 9 commits intodahall:masterfrom
Conversation
tajbender
commented
Mar 12, 2026
Contributor
Author
tajbender
left a comment
There was a problem hiding this comment.
Update build enviroment
tajbender
commented
Mar 12, 2026
Contributor
Author
There was a problem hiding this comment.
used default values, i don't need em
tajbender
commented
Mar 12, 2026
Contributor
Author
There was a problem hiding this comment.
used default values, i don't need em
tajbender
commented
Mar 12, 2026
Contributor
Author
There was a problem hiding this comment.
used default values, i don't need em
tajbender
commented
Mar 12, 2026
Contributor
Author
There was a problem hiding this comment.
used default values, i don't need em
tajbender
commented
Mar 12, 2026
Contributor
Author
tajbender
left a comment
There was a problem hiding this comment.
.idea config files should be removed.
Vanara.WinUI.Extensions build environment
tajbender
commented
Mar 12, 2026
Contributor
Author
There was a problem hiding this comment.
Needs updates and refactoring.
@dahall overhaul threading issues please
public class SoftwareBitmapSource : Microsoft.UI.Xaml.Media.Imaging.SoftwareBitmapSource
{
public IconSize IconSize { get; }
public SoftwareBitmapSource(IconSize iconSize) => IconSize = iconSize;
}
public static async Task<SoftwareBitmapSource> GetWinUi3BitmapSourceFromIcon(Icon bitmapIcon, IconSize iconSize)
{
ArgumentNullException.ThrowIfNull(bitmapIcon);
// TODO: use iconSize...: var hIcon = Shell32.SHGetFileInfo(..., (int)iconSize);
return await GetWinUi3BitmapSourceFromGdiBitmap(bitmapIcon.ToBitmap());
}
if (gdiBitmap.PixelFormat != PixelFormat.Format32bppArgb)
gdiBitmap = gdiBitmap.Clone(new Rectangle(0,0,w,h), PixelFormat.Format32bppArgb);
var ms = new MemoryStream();
icon.Save(ms);
ms.Position = 0;
var bmp = new BitmapImage();
bmp.SetSource(ms.AsRandomAccessStream());
return bmp;
Merge head to base repository
Contributor
Author
|
Update: I'll jump to Current state:Rebuilding environment, Cleaning up, putting WinUi Shell32 Controls into WinClassicSamplesBrowser for integration testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Vanara.WinUI.Extensionsto at least