Add missing submodule init step to VCSRender build instructions#3
Open
caffodian wants to merge 1 commit intodaily-co:mainfrom
Open
Add missing submodule init step to VCSRender build instructions#3caffodian wants to merge 1 commit intodaily-co:mainfrom
caffodian wants to merge 1 commit intodaily-co:mainfrom
Conversation
The build instructions omitted the required `git submodule init && git submodule update` step, causing builds to fail due to missing submodule dependencies (e.g. canvex-skia). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hi friends from Daily. I ran into this while trying to get the VCS thingy setup locally, so figured it would help someone else. I guess it technically says to read that repo's README, but it does seem to need the submodule init regardless of the state of your meson install. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git submodule init && git submodule updatestep to the VCSRender build instructions in the READMEcanvex-skia)Test plan
🤖 Generated with Claude Code