Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .agents/journal/scribe-journal.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,8 @@

**Learning:** The documentation for `skill suggest` incorrectly stated that detection confidence was determined by file location (root-level vs nested) or directory type (test/example). In reality, the `CatalogDrivenDetector` in `src/skills/detect.rs` assigns confidence based on the detection mechanism: `High` for exact package matches and configuration file existence, and `Medium` for regex patterns, content matches, and file extensions.
**Action:** Always verify the mapping between internal enums (like `DetectionConfidence`) and detection rules in `src/skills/detect.rs` rather than assuming location-based heuristics.

## 2026-08-05 - Missing Skill Registry Subcommands in Reference

**Learning:** The `agentsync skill registry` subcommand (with its `validate` and `sync` options) was completely missing from the CLI reference page. Additionally, an obsolete sidebar configuration format in Starlight for autogenerated directories was causing the Astro website build to fail during pre-commit checks.
**Action:** Always verify subcommands against the implementation file (`src/commands/skill.rs`), and ensure all pre-commit builds compile cleanly in the target documentation theme environment (e.g., Starlight/Astro).
2 changes: 1 addition & 1 deletion website/docs/astro.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default defineConfig({
},
{
label: "Reference",
autogenerate: { directory: "reference" },
items: [{ autogenerate: { directory: "reference" } }],
},
],
}),
Expand Down
32 changes: 32 additions & 0 deletions website/docs/src/content/docs/reference/cli.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,38 @@ List all installed skills.
agentsync skill list
```

#### `registry`

Validate and refresh the maintainer curated registry.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Hyphenate the compound modifier.

Change maintainer curated registry to maintainer-curated registry.

LanguageTool flagged this line.

🧰 Tools
🪛 LanguageTool

[grammar] ~292-~292: Use a hyphen to join words.
Context: ...ry` Validate and refresh the maintainer curated registry. ```bash agentsync ski...

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@website/docs/src/content/docs/reference/cli.mdx` at line 292, Update the
documentation text “maintainer curated registry” to “maintainer-curated
registry” in the registry validation statement.

Source: Linters/SAST tools


```bash
agentsync skill registry <COMMAND>
```

##### `validate`

Validate a curated registry manifest against its lockfile constraints.

```bash
agentsync skill registry validate [OPTIONS]
```

**Options**:
- `--manifest <MANIFEST>`: Path to the registry manifest file (defaults to `src/skills/registry.v1.toml`).
- `--lock <LOCK>`: Path to the registry lockfile (defaults to `src/skills/registry.lock.toml`).
Comment on lines +300 to +308

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Do not document validate as a lockfile check.

The runtime passes only args.manifest to load_curated_registry. The --lock path is not read or compared. This makes both the description and the --lock option misleading.

Document validate as manifest-only and remove --lock, unless the CLI implementation is changed to validate the lockfile.

Proposed documentation fix
-Validate a curated registry manifest against its lockfile constraints.
+Validate a curated registry manifest.
...
- - `--lock <LOCK>`: Path to the registry lockfile (defaults to `src/skills/registry.lock.toml`).

This assessment uses the supplied runtime snippets in src/commands/skill.rs, Lines [790-805], and src/skills/registry.rs, Lines [69-78].

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Validate a curated registry manifest against its lockfile constraints.
```bash
agentsync skill registry validate [OPTIONS]
```
**Options**:
- `--manifest <MANIFEST>`: Path to the registry manifest file (defaults to `src/skills/registry.v1.toml`).
- `--lock <LOCK>`: Path to the registry lockfile (defaults to `src/skills/registry.lock.toml`).
Validate a curated registry manifest.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@website/docs/src/content/docs/reference/cli.mdx` around lines 300 - 308,
Update the validate command documentation to describe manifest-only validation,
matching the runtime behavior of load_curated_registry in the validate flow.
Remove the --lock option and its default path from the documented options,
unless the implementation is first changed to load and compare the lockfile.


##### `sync`

Validate a curated registry manifest and atomically regenerate its lockfile.

```bash
agentsync skill registry sync [OPTIONS]
```

**Options**:
- `--manifest <MANIFEST>`: Path to the registry manifest file (defaults to `src/skills/registry.v1.toml`).
- `--lock <LOCK>`: Path to the registry lockfile (defaults to `src/skills/registry.lock.toml`).

---

### `doctor`
Expand Down
Loading